Skip to content

feat: export core type as schema#36401

Merged
ggazzo merged 1 commit intodevelopfrom
chore/core-schema
Jul 11, 2025
Merged

feat: export core type as schema#36401
ggazzo merged 1 commit intodevelopfrom
chore/core-schema

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 11, 2025 •
edited
Loading

The idea is to automatically convert our most commonly used entities, avoiding repetition and errors. This way, the endpoints can use $ref, reducing the implementation size and speeding up the development process.
https://rocketchat.atlassian.net/browse/ARCH-1707

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 11, 2025 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3383bb7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo added this to the 7.9.0 milestone Jul 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025 •
edited
Loading

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36401/

Built to branch gh-pages at 2025-07-11 14:52 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.76%. Comparing base (b10ce3b) to head (3383bb7).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36401      +/-   ##
===========================================
+ Coverage    64.74%   64.76%   +0.02%     
===========================================
  Files         3156     3156              
  Lines       104912   104912              
  Branches     19957    19958       +1     
===========================================
+ Hits         67921    67942      +21     
+ Misses       34303    34283      -20     
+ Partials      2688     2687       -1
Flag Coverage Δ
e2e 57.62% <ø> (+0.04%) ⬆️
unit 69.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo force-pushed the chore/core-schema branch from a636e88 to 3383bb7 Compare July 11, 2025 14:48
@ggazzo ggazzo marked this pull request as ready for review July 11, 2025 14:52
@ggazzo ggazzo requested review from a team as code owners July 11, 2025 14:52
@ggazzo ggazzo merged commit 8c951f8 into develop Jul 11, 2025
87 of 89 checks passed
@ggazzo ggazzo deleted the chore/core-schema branch July 11, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ggazzo @MarcosSpessatto